Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postprocessing. Optimization. #4927

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

querielo
Copy link
Contributor

@querielo querielo commented Dec 15, 2022

Fixes post processing in case of disabled layer

Demo project (open it and you see a black screen): https://playcanvas.com/project/1019833/overview/bug-postprocessing
Screen Shot 2022-12-15 at 19 23 27

The PR doesn't create RenderAction for disabled layers.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor Author

@querielo querielo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fir postprocessing

@yaustar yaustar requested review from mvaligursky and a team December 15, 2022 15:30
@yaustar yaustar added bug area: graphics Graphics related issue labels Dec 15, 2022
@querielo querielo changed the title Fix postprocessing Fix postprocessing. Optimization. Dec 15, 2022
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@mvaligursky mvaligursky self-assigned this Dec 15, 2022
@mvaligursky mvaligursky merged commit 581a0e1 into playcanvas:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants