Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix to light options processing causing clustered shaders compilation when lights change #4955

Merged
merged 1 commit into from Jan 9, 2023
Merged

[Fix] Fix to light options processing causing clustered shaders compilation when lights change #4955

merged 1 commit into from Jan 9, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 9, 2023 •
edited

  • fixes a regression introduced in Options split #4792 when light options were always copied, and should be ignored for local lights when clustered lighting is enabled

This was causing new shader to be created / compiled in ClusteredSpotLIghts example when adding lights.

image

@mvaligursky mvaligursky self-assigned this Jan 9, 2023
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Jan 9, 2023
@mvaligursky mvaligursky merged commit 4199b6d into main Jan 9, 2023
@mvaligursky mvaligursky deleted the mv-clustered-options-fix branch January 9, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @slimbuck