Update to WebGL shader compilation and linking #4964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3559
Situation before:
Situation now:
What this delivers is conceptually this (2 meshes with 2 shaders):
Before:
Now:
Note that those loops execute per render layer / render pass, so shadows would do compile/link/finalize on shaders before main forward pass woud.
The actual log from multi-view engine example (the number is unique ID of the shader):
In a larger project, I see a lot more shaders getting compiled before any linking, for example
So in theory, this does the right thing, but in practise, on few projects I have tried, I cannot see a performance difference (using Chrome on both MacOS and Windows).