New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize morph target animation creation from glb data #5140

Merged

mvaligursky merged 1 commit into main from mv-morph-anim-optimization

Mar 10, 2023

Contributor

mvaligursky commented Mar 10, 2023 •

edited

This seems to about half the duration of createMorphTargetCurves, which is large part of loading animations with morph curves:

using single typed array allocation, and assigning range from it, instead of many allocations
not calling retrieveWeightName each time, but executing most of it just one time


          Optimize morph target animation creation from glb data

db483e7

mvaligursky self-assigned this

mvaligursky added performance area: animation labels

mvaligursky requested review from ellthompson and slimbuck

March 10, 2023 10:42

slimbuck approved these changes

View reviewed changes

mvaligursky merged commit 24b2377 into main

mvaligursky deleted the mv-morph-anim-optimization branch

March 10, 2023 12:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment