Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU renderer handles canvas size change #5148

Merged
merged 3 commits into from Mar 14, 2023
Merged

WebGPU renderer handles canvas size change #5148

merged 3 commits into from Mar 14, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 13, 2023 •
edited

Canvas changes are handled by WebgpuGraphicsDevice, allowing Engine examples window to be resized without crashes.

Additionally:

  • an internal WebgpuDebug class has been created, which is a wrapper over webgpu error scopes, allows easier error handling. Note that this is used in Debug mode only, and stripped out otherwise.

@mvaligursky mvaligursky self-assigned this Mar 13, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Mar 13, 2023
@mvaligursky mvaligursky merged commit fefc153 into main Mar 14, 2023
@mvaligursky mvaligursky deleted the mv-webgpu-resize branch March 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott