New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change raycastAll
sorting default to false
#5181
Change raycastAll
sorting default to false
#5181
Conversation
Hey, thank you for this one! However, I would like to reiterate, that my view on this still stands as the default option (when no options specified) should be non-sorted result. And if a developer wants a sorting, it would be enabled via options or do own sorting on the results that would match their game logic. |
raycastAll
sorting default to false
Then it becomes breaking change, but there you go. Placing #5180 back on draft as if this change gets merged the code will need to be updated. |
Thank you! I don't think it is a breaking change, unless it changes the code that was already released. I will leave it up to @willeastcott to decide. |
Correct, this is not a breaking change, as it matches the currently released engine. |
raycastAll
sorting default to falseraycastAll
sorting default to false
Oh alright, I was referring at the current repo state but yeah that makes sense if that's from the released state! |
raycastAll
sorting default to falseraycastAll
sorting default to false
As requested by @LeXXik in #5179, added an
options
parameter toraycastAll
to allow non-sorting of results.Changes to
RigidBodyComponentSystem
public API:raycastFirst(start, end, options)
raycastAll(start, end, options)
Options declares as follow for not sorting:
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.