Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small cleanup to Particle System #5279

Merged
merged 2 commits into from Apr 27, 2023
Merged

Small cleanup to Particle System #5279

merged 2 commits into from Apr 27, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Apr 26, 2023 •
edited

  • converted ParticleSpark example to use createGraphicsDevice
  • removed never used texture sampler from particle shader
  • added PARTICLE_CPU / PARTICLE_GPU define to particle shaders (not used at the moment, but will be used when cleaning up shaders for WebGPU)
  • debug name generation improvement / fix

@mvaligursky mvaligursky self-assigned this Apr 26, 2023
@mvaligursky mvaligursky merged commit 7f9cfd7 into main Apr 27, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-particle-cleanup branch April 27, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott