Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples load envLighting without mipmaps #5300

Merged
merged 1 commit into from May 3, 2023
Merged

Examples load envLighting without mipmaps #5300

merged 1 commit into from May 3, 2023

Conversation

mvaligursky
Copy link
Contributor

  • this is to avoid the mipmap flag being changed after the texture has been created, which is not supported by WebGPU device at the moment

@mvaligursky mvaligursky self-assigned this May 3, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label May 3, 2023
@mvaligursky mvaligursky merged commit 2ed765a into main May 3, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-nomips-envlighting branch May 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

@GSterbrant GSterbrant Awaiting requested review from GSterbrant

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @slimbuck