Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to static members of BlendState #5303

Merged
merged 1 commit into from May 3, 2023
Merged

Change to static members of BlendState #5303

merged 1 commit into from May 3, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented May 3, 2023 •
edited

  • deprecated BlendState.DEFAULT due to non-obvious naming
  • replaced it by BlendState.NOBLEND
  • added BlendState.ALPHABLEND which is commonly used

@mvaligursky mvaligursky self-assigned this May 3, 2023
willeastcott
willeastcott approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvement. Thanks.

@mvaligursky mvaligursky merged commit e63821d into main May 3, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-blend-states-constants branch May 3, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@GSterbrant GSterbrant GSterbrant approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvaligursky @willeastcott @GSterbrant