Downgrade draco assert to warning #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
May 10, 2023
src/framework/parsers/glb-parser.js
Outdated
| Debug.assert(numVertices === accessors[primitive.attributes.POSITION].count, 'mesh has invalid draco sizes'); | ||
| if (numVertices !== accessors[primitive.attributes.POSITION].count) { | ||
| Debug.warn('mesh has invalid draco sizes'); | ||
| } |
There was a problem hiding this comment.
add the whole thing inside Debug.call(() => { } so that even the condition gets stripped out
and maybe add that glb name if possible
and warnOnce could be good as well
There was a problem hiding this comment.
+1 on some identifier would be great
There was a problem hiding this comment.
Projects don't need reimport TBH. We'll patch the engine with this change now so we can get it out quickly, then add more debugging information later.
mvaligursky
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is not fatal, downgrade to warning.