Calculate draco indices #5316
Merged
Calculate draco indices #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
May 10, 2023
| Debug.warn('mesh has invalid vertex count'); | ||
| } | ||
| if (numIndices !== accessors[primitive.indices].count) { | ||
| Debug.warn('mesh has invalid index count'); |
There was a problem hiding this comment.
still no way to print the glb name? Without it i's not super useful message.
There was a problem hiding this comment.
nope. user doesn't need to do anything anyway.
mvaligursky
approved these changes
May 10, 2023
willeastcott
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #5208.
An old version of the playcanvas glb converter was writing incorrect count values for number of vertices and indices in some cases.
This PR ignores the values written in the file json and uses the counts returned from draco instead.