Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draco url fix #5325

Merged
merged 3 commits into from May 12, 2023
Merged

Draco url fix #5325

merged 3 commits into from May 12, 2023

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented May 12, 2023

Fixes: #5323

Use relative URLs for draco loading.

Absolute URLs are needed when web workers perform network requests. However the main thread is downloading and compiling the module.

@slimbuck slimbuck added the area: graphics Graphics related issue label May 12, 2023
@slimbuck slimbuck requested a review from a team May 12, 2023 13:24
@slimbuck slimbuck self-assigned this May 12, 2023
@slimbuck slimbuck merged commit 95d9e53 into playcanvas:main May 12, 2023
7 checks passed
@slimbuck slimbuck deleted the draco-url-fix branch May 12, 2023 13:28
slimbuck added a commit that referenced this pull request May 12, 2023
* no need for absolute url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draco WASM does not load when used in WebViews like Electron apps
2 participants