Do not declare MRT shader ouputs over the specified number #5395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5393
We used to declare 8 MRT outputs for all fragment shaders, assuming the compiler would ignore unused ones. Turns out this fails on some android devices that only support 4 attachments.
This PR addresses it by only declaring supported outputs, by stripping unsupported outputs using ifdefs. On a device with only 4 attachments, the generated code (after the pre-processor steps) looks like this, with only 4 instead of 8 outputs: