Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimBlendTree fix #5401

Merged
merged 3 commits into from Jun 15, 2023
Merged

AnimBlendTree fix #5401

merged 3 commits into from Jun 15, 2023

Conversation

ellthompson
Copy link
Contributor

@ellthompson ellthompson commented Jun 15, 2023

The findParameter and comsumeTrigger functions should always be called in the AnimController's scope so that they have access to its private variables. Setting these functions as anonymous ensures they are always called with this scope, even when they are passed to and called by the various AnimBlendTree classes.

Fixes #5398

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@ellthompson ellthompson added bug area: animation Animation related issue labels Jun 15, 2023
@ellthompson ellthompson self-assigned this Jun 15, 2023
@ellthompson ellthompson requested a review from a team June 15, 2023 12:35
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the explanation to those functions (similar as the PR's description), as it's not obvious.

@ellthompson ellthompson merged commit 89283b7 into main Jun 15, 2023
7 checks passed
@ellthompson ellthompson deleted the find-parameter-fix branch June 15, 2023 13:54
mvaligursky pushed a commit that referenced this pull request Jun 16, 2023
* make the fineParameter and comsumeTrigger functions anonymous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animation Animation related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple animation engine examples fail to run
2 participants