Simplify the normal offset shadow coordinate method for clustered point lights #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he direction instead of changing dLightDirW.
mvaligursky
approved these changes
Jun 21, 2023
slimbuck
pushed a commit
that referenced
this pull request
Jun 22, 2023
…he direction instead of changing dLightDirW. (#5425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
normalOffsetPointShadowmethod previously changed the dLightDirW parameter to only use it on the line below. This was left in the clustered light shader for backwards compatibility, but this can now be changed to return the offsetted direction, making the code much cleaner.