Compensate PCSS kernel with depth range for directional lights #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSterbrant
force-pushed
the
gsterbrant-pcss-directional-fixes
branch
from
6cd276b
to
2616d1a
Compare
mvaligursky
reviewed
Jun 27, 2023
GSterbrant
commented
Jun 27, 2023
src/scene/light.js
Outdated
| @@ -65,6 +65,9 @@ class LightRenderData { | |||
| // scissor rectangle for the shadow rendering to the texture (x, y, width, height) | |||
| this.shadowScissor = new Vec4(0, 0, 1, 1); | |||
|
|
|||
| // depth range for cascaded shadows | |||
| this.depthRange = 0; | |||
mvaligursky
reviewed
Jun 27, 2023
mvaligursky
reviewed
Jun 27, 2023
…ta and submit directly.
mvaligursky
approved these changes
Jun 27, 2023
mvaligursky
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Compensate PCSS kernel with depth range for directional lights * Copy depth range values to render data and initialize properly. * Save only the depth range compensation we want in the light render data and submit directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCSS reacts differently based on scene size with directional lights. This PR fixes that by compensating the depth differences caused by a change in the depth range.