Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples Browser] Engine sourcemaps fix #5447

Merged
merged 1 commit into from Jun 29, 2023
Merged

Conversation

ellthompson
Copy link
Contributor

Sourcemaps for the engine were not showing up in the examples browser. This is because rollup doesn't bundle the sourcemaps of imported files by default. This PR introduces a sourcemaps plugin which handles this functionality.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@ellthompson ellthompson requested a review from a team June 29, 2023 10:49
@ellthompson ellthompson self-assigned this Jun 29, 2023
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thanks

@ellthompson ellthompson merged commit 5d0f402 into main Jun 29, 2023
7 checks passed
@ellthompson ellthompson deleted the examples-sourcemap-fix branch June 29, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants