Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write to FragDepth unless depth value is modified #5451

Merged
merged 1 commit into from Jun 30, 2023

Conversation

GSterbrant
Copy link
Contributor

Fixed some blinking issues seen with WebGPU.

Not sure what the cause of this is yet, but this PR makes sure the shadow output shaders export the same values as they did before the shadow export refactor in #5446

@GSterbrant GSterbrant added bug area: graphics Graphics related issue labels Jun 30, 2023
@GSterbrant GSterbrant self-assigned this Jun 30, 2023
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, we don't want to write out depth unless we have to, as that comes at a cost.

@GSterbrant GSterbrant merged commit 670f418 into main Jun 30, 2023
7 checks passed
@GSterbrant GSterbrant deleted the gsterbrant-fix-webgpu-shadows branch June 30, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants