Only rebuild shaders on sky rotation change if changing away from identity #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
reviewed
Jul 10, 2023
slimbuck
approved these changes
Jul 13, 2023
mvaligursky
added a commit
that referenced
this pull request
Jul 17, 2023
…ntity (#5467) * Only rebuild shaders on sky rotation change if changing away from identity * update based on comment * lint --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5458
Don't rebuild shaders if rotation changes, only if it changes and it was identity before, which requires shaders to be re-generated to include support for rotation, which is excluded when identity.