Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized the key generation for StencilParameters #5491

Merged
merged 2 commits into from Jul 20, 2023
Merged

Optimized the key generation for StencilParameters #5491

merged 2 commits into from Jul 20, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 20, 2023 •
edited

The only render state which didn't cache the key generation, causing this to be evaluated each frame (for the DEFAULT).

@mvaligursky mvaligursky self-assigned this Jul 20, 2023
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Jul 20, 2023
@mvaligursky @willeastcott
Update src/platform/graphics/stencil-parameters.js
7e2157d 
Co-authored-by: Will Eastcott <will@playcanvas.com>
@mvaligursky mvaligursky merged commit ddc0fda into main Jul 20, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-stencil-key branch July 20, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott