Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MeshInstance.transparent to optimize access to it #5516

Merged
merged 1 commit into from Jul 28, 2023
Merged

Add MeshInstance.transparent to optimize access to it #5516

merged 1 commit into from Jul 28, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 28, 2023 •
edited

  • meshInstance.transparent as a fast way to access meshInstance.material.transparent. This is set by the material on all mesh instances that use it.
  • not much win for now, but is needed in follow up PRs as this will be access per frame during culling

@mvaligursky mvaligursky self-assigned this Jul 28, 2023
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue labels Jul 28, 2023
@mvaligursky mvaligursky merged commit 9254d15 into main Jul 28, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-meshinstance-transparent branch July 28, 2023 12:05
@mvaligursky mvaligursky mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@slimbuck slimbuck Awaiting requested review from slimbuck

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @willeastcott