[Fix] Avoid additional shaders creation caused by out of order lights #5550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Aug 4, 2023
mvaligursky
added a commit
that referenced
this pull request
Aug 16, 2023
…#5550) * [Fix] Avoid additional shaders creation caused by out of order lights * don’t include vertex format to be part of processing key on WebGL * updates --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5542
When lights stored by the Layer were in different order, a different key would be generated causing new shaders to be created.
To avoid this, the lights the Layer stores are sorted by their key.
Additionally, small refactor related to shader key generation has been done, making those multiline and easier to read, and storing those on the Shader instance in debug mode, to allow us to easily compare why a shader was generated (see the generation and processing keys)