Refactor shader caching to handle mesh instance on layers with different lights #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2023 14:54
Co-authored-by: Will Eastcott <will@playcanvas.com>
willeastcott
approved these changes
Aug 23, 2023
| * | ||
| * @ignore | ||
| */ | ||
| class ShaderInstance { |
There was a problem hiding this comment.
Should this go in its own module?
There was a problem hiding this comment.
I decided against it for now, as it's just internal to mesh instance, not even exported.
mvaligursky
added a commit
that referenced
this pull request
Aug 23, 2023
…ent lights (#5582) * Refactor shader caching to handle mesh instance on layers with different lights * lint * Update src/scene/materials/material.js Co-authored-by: Will Eastcott <will@playcanvas.com> * removed --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache of shaders on the mesh instance only supported a single set of lights, by storing _lightHash value. This does not work when the same mesh instance is used on multiple layers, with different sets of lights, causing shader cache miss each time.
This has been refactored now to be supported. Further refactoring has been done to storing bind groups that match the shaders.
Some deprecated functionality, in the past used by the Editor, has been removed now as well, as it's being removed from the Editor.