Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted Picker to use render pass internally #5608

Merged
merged 3 commits into from Sep 5, 2023
Merged

Converted Picker to use render pass internally #5608

merged 3 commits into from Sep 5, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Sep 4, 2023 •
edited

  • Picked no longer uses custom LayerComposition with a Layer which gets mesh instances added to, but instead using Rendered and RenderPass to render visible meshes for the camera.
  • this also removes Command class, as the only use for it was to clear the depth by the Picker

Note: hide whitespaces when diffing.

@mvaligursky mvaligursky self-assigned this Sep 4, 2023
@mvaligursky mvaligursky merged commit f9a793d into main Sep 5, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-picker-render-pass branch September 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @slimbuck