When the context is lost, silently ignore failed shader compilation #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
approved these changes
Sep 18, 2023
|
Can I simply cheery pick webgl-shader.js file and apply it to 1.65.3 version? |
|
Yep that should work without a problem @figo2264 |
mvaligursky
added a commit
that referenced
this pull request
Sep 25, 2023
…5644) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the context is lost, all gl functionality should silently work, but
gl.createShaderreturns null (which documentation of the function does not mentioned). This generates an error in the application.The solution in this PR is to silently ignore shader compilation / linking errors when the device is lost, as those are compiled again when the device is restored, avoiding logging errors without real error message.
Related to https://forum.playcanvas.com/t/what-cause-webgl-context-lost/32886
Tested using CompileShader example, modified to compile a shader each frame - the errors are gone and all works correctly when the context is restored.