Refactoring to LayerComposition internal implementation #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Oct 10, 2023
•
mvaligursky
commented
- LayerCompositions has additional maps to look up index of sublayers, plus few related optimisations
- RenderAction no longer stores sublayer index
- LayerComposition is updated when a layer.enable state changes - so we no longer need to handle this during rendering
- Mesh Instance culling using cameras / layers directly instead of composition / RenderActions, to be easy to use with custom RenderPassRenderAction instances that are not part of the composition.
…ith custom passes with customer render actions
willeastcott
approved these changes
Oct 10, 2023
Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.