Custom render passes on a camera #5741

mvaligursky · 2023-10-11T14:30:56Z

an API (private for now) on the Camera to allow render passes for its rendering to be added to it.
those passes are then inserted into the frame graph by forward renderer, allowing rendering the camera using custom render passes.

Suggestion: Hide whitespaces when reviewing.

src/scene/composition/render-action.js

slimbuck · 2023-10-14T12:08:43Z

src/scene/frame-graph.js

+
+        const passes = this.renderPasses;
+
+        const beforePasses = renderPass.beforePasses;


Why not?
passes = renderPass.beforePasses.filter(p => p.enabled)

this runs every frame, so performance is the reason
https://plainenglish.io/blog/are-for-loops-better-than-arrays-filter-or-foreach-methods

Custom render passes on a camera

eee8b19

mvaligursky self-assigned this Oct 11, 2023

lint

0a98bb1

mvaligursky added feature request area: graphics Graphics related issue labels Oct 11, 2023

mvaligursky requested review from marklundin, willeastcott and slimbuck October 11, 2023 14:34

Martin Valigursky added 2 commits October 11, 2023 15:37

lint

9c111b6

Merge branch 'main' into mv-camera-render-passes

3fbbb08

mvaligursky requested a review from isumygin-sc October 12, 2023 11:19

Martin Valigursky added 4 commits October 13, 2023 13:31

converted multiple generic passes to modules

d869fda

lint

3630393

dependent render passes test

881a4a8

fix

3d30a76

slimbuck approved these changes Oct 14, 2023

View reviewed changes

mvaligursky merged commit 6ade569 into main Oct 16, 2023
7 checks passed

mvaligursky deleted the mv-camera-render-passes branch October 16, 2023 08:08

mvaligursky mentioned this pull request Dec 1, 2023

[Fix] Framebuffer clear flags on the Layer were not correctly used #5875

Merged

Provide feedback


		const passes = this.renderPasses;

		const beforePasses = renderPass.beforePasses;