WebXR fix Hit Test providing multiple results #5778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Nov 6, 2023
mvaligursky
approved these changes
Nov 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on WebXR specs, it is possible to query hit test results for specific input sources, but it is done using
profilearray string. As left / right controllers have the same profile string, then hit test source can report information from various input sources. This PR fixes that, and ensures that HitTestSource firesresultevent only for the input source it is related to.Additionally underlying systems can provide multiple results per hit test source as ray can pass through multiple planes. Previously only devices with a single result were present, so this PR updates that, and ensures that single (closest) result is returned. If there will be a need for returning multiple results, then additional PR with
resultsAllcallback probably can be made.Example with AR Hit Test is updated to include additional input sources (screen taps, controllers and hands).
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.