Examples: Use actual component to hide spinner #5782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5781
(I would still like some feedback from @Maksims about which example/OS was affected to test this on my side, in the meantime I will update the live browser so we can easily test it)
Edit:
This PR doesn't just
display:none
but removing it from the DOM. Testable viadocument.getElementsByClassName("spin")
:Updated Examples browser for this PR: https://examples.killtube.org/#/misc/hello-world
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.