[Fix] When the default framebuffer is updated, refresh info about its format #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
changed the title
mvaligursky
added
bug
area: graphics
slimbuck
reviewed
Nov 3, 2023
slimbuck
approved these changes
Nov 3, 2023
marklundin
pushed a commit
that referenced
this pull request
Nov 3, 2023
… format (#5784) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
mvaligursky
added a commit
that referenced
this pull request
Nov 6, 2023
… format (#5784) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5775
When the default framebuffer changes (for example entering or exiting XR), detect its pixel format, as that is required to create a matching multi-sampled framebuffer.
Without this, the multi-sampled framebuffer could have different format (alpha channel) and resolve blit would fail.