Splat updates #5808
Merged
Splat updates #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
reviewed
Nov 8, 2023
| @@ -163,7 +188,10 @@ class SplatSorter { | |||
| data: oldData | |||
| }, [oldData]); | |||
|
|
|||
| this.vertexBuffer.setData(newData); | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
Just wondering why the setTimeout is required...
There was a problem hiding this comment.
Without the setTimeout, the postMessage above will only be enqueued after setData has finished executing (setData can be slooow). With the setTimeout, postMessage is sent immediately and the worker can start sorting for the next round while setData completes.
I've confirmed this using Chrome profiler, but it's possible we can do better.
There was a problem hiding this comment.
Worthy of a comment in the code?
willeastcott
approved these changes
Nov 8, 2023
willeastcott
approved these changes
Nov 9, 2023
mvaligursky
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR to #5785 and adds a few bits required in SuperSplat:
updatedevent to sorter so editors can re-draw the scene even when camera is static