Expose custom shader modifications of the splat shader #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimbuck
reviewed
Nov 9, 2023
| @@ -32,11 +32,12 @@ class SplatInstance { | |||
|
|
|||
| lastCameraDirection = new Vec3(); | |||
|
|
|||
| constructor(splat, cameraEntity, debugRender = false) { | |||
| constructor(splat, options) { | |||
There was a problem hiding this comment.
Might be worth documenting these options.
There was a problem hiding this comment.
Yep. At the moment none of the splat code has jsdocs, so that's all for a separate PR.
| this.splat = splat; | ||
|
|
||
| // material | ||
| this.material = splat.createMaterial(debugRender); | ||
| const debugRender = options.debugRender; | ||
| this.material = splat.createMaterial(options); |
There was a problem hiding this comment.
It would be good if we also supported user passing in material.
There was a problem hiding this comment.
separate PR. But not sure how that would work with a compute shader implementation on WebGPU, so I would not do that yet.
| @@ -63,8 +63,8 @@ class Splat { | |||
| this.centerTexture.destroy(); | |||
| } | |||
|
|
|||
| createMaterial(debugRender = false) { | |||
| const material = createSplatMaterial(this.device, debugRender); | |||
| createMaterial(options) { | |||
There was a problem hiding this comment.
Think we should document options.
slimbuck
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dancing.guitar.mov