Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scheduling of directional light shadow render passes to be compatible with manual render passes #5845

Merged
merged 1 commit into from Nov 27, 2023
Merged

Update scheduling of directional light shadow render passes to be compatible with manual render passes #5845

merged 1 commit into from Nov 27, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 24, 2023 •
edited

Fixes #5844

  • added a directional shadow casting light to post-processing example
  • updated RenderPassRenderAction to automatically schedule required shadow passes for directional light before it
  • this is done by tracking the camera that the directional shadow is currently rendered for, and scheduling rendering if a new camera is used

@mvaligursky mvaligursky self-assigned this Nov 24, 2023
@mvaligursky mvaligursky merged commit f55f448 into main Nov 27, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-dirlight-renderpass branch November 27, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@marklundin marklundin Awaiting requested review from marklundin

@isumygin-sc isumygin-sc Awaiting requested review from isumygin-sc

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bloom PostProcessing example, error thrown when light is added
2 participants
@mvaligursky @slimbuck