Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs 404 for XrAnchorCreateCallback #5880

Merged
merged 1 commit into from Dec 5, 2023
Merged

Fix docs 404 for XrAnchorCreateCallback #5880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/framework/xr/xr-anchors.js
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@ import { XrAnchor } from './xr-anchor.js';
/**
* Callback used by {@link XrAnchors#create}.
*
* @callback XrAnchorCreate
* @callback XrAnchorCreateCallback
* @param {Error|null} err - The Error object if failed to create an anchor or null.
* @param {XrAnchor|null} anchor - The anchor that is tracked against real world geometry.
*/
Expand Down Expand Up @@ -72,7 +72,7 @@ class XrAnchors extends EventHandler {
* Map of callbacks to XRAnchors so that we can call its callback once
* an anchor is updated with a pose for the first time.
*
* @type {Map<XrAnchor,XrAnchorCreate>}
* @type {Map<XrAnchor, XrAnchorCreateCallback>}
* @private
*/
_callbacksAnchors = new Map();
Expand Down Expand Up @@ -174,8 +174,8 @@ class XrAnchors extends EventHandler {
* Create anchor with position, rotation and a callback.
*
* @param {import('../../core/math/vec3.js').Vec3|XRHitTestResult} position - Position for an anchor.
* @param {import('../../core/math/quat.js').Quat|XrAnchorCreate} [rotation] - Rotation for an anchor.
* @param {XrAnchorCreate} [callback] - Callback to fire when anchor was created or failed to be created.
* @param {import('../../core/math/quat.js').Quat|XrAnchorCreateCallback} [rotation] - Rotation for an anchor.
* @param {XrAnchorCreateCallback} [callback] - Callback to fire when anchor was created or failed to be created.
* @example
* // create an anchor using a position and rotation
* app.xr.anchors.create(position, rotation, function (err, anchor) {
Expand Down Expand Up @@ -231,7 +231,7 @@ class XrAnchors extends EventHandler {
* Restore anchor using persistent UUID.
*
* @param {string} uuid - UUID string associated with persistent anchor.
* @param {XrAnchorCreate} [callback] - Callback to fire when anchor was created or failed to be created.
* @param {XrAnchorCreateCallback} [callback] - Callback to fire when anchor was created or failed to be created.
* @example
* // restore an anchor using uuid string
* app.xr.anchors.restore(uuid, function (err, anchor) {
Expand Down