Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of shader generator for Splat Materials supporting gamma and tonemapping options #5900

Merged
merged 2 commits into from Dec 15, 2023
Merged

Implementation of shader generator for Splat Materials supporting gamma and tonemapping options #5900

merged 2 commits into from Dec 15, 2023

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Dec 15, 2023 •
edited

  • shader gets cached / generated during the rendering, respecting current gamma and tonemapping scene settings
  • this allows it to correctly integrate with the HDR pipeline

Screenshot 2023-12-15 at 11 36 45

@mvaligursky mvaligursky self-assigned this Dec 15, 2023
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Dec 15, 2023
@mvaligursky mvaligursky requested a review from a team December 15, 2023 11:42
@mvaligursky mvaligursky merged commit eb7f939 into main Dec 15, 2023
7 checks passed
@mvaligursky mvaligursky deleted the mv-splat-shader-gen branch December 15, 2023 11:50
@LeXXik
Copy link
Contributor

LeXXik commented Dec 15, 2023

Will looks so tiny :)

@mvaligursky
Copy link
Contributor Author

mvaligursky commented Dec 15, 2023 •
edited

Not from this side! :)

Screenshot 2023-12-15 at 11 52 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvaligursky @LeXXik @willeastcott