Make more examples WebGPU compatible #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch examples from using pc.AppBase instead of pc.Application. This allows the examples to be WebGPU compatible. TransformFeedbackExample, VideoTextureExample and PositionalExample have been updated but have WEBGPU_ENABLED = false as they don't work with WebGPU yet. I have added a comment to each for why.
mvaligursky
approved these changes
Jan 8, 2024
|
improvement to the positional example here: #5932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch examples from using
pc.AppBaseinstead ofpc.Application. This allows the examples to be WebGPU compatible.TransformFeedbackExample,VideoTextureExampleandPositionalExamplehave been updated but haveWEBGPU_ENABLED = falseas they don't work with WebGPU yet. I have added a comment to each for why.I confirm I have read the contributing guidelines and signed the Contributor License Agreement.