Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VertexArrayObject polyfill for IE11 #5957

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 19, 2024

We no longer support IE11, and so this extension can go, as the VAO functionality is otherwise well covered by OES_vertex_array_object extension on WebGL1:

Screenshot 2024-01-19 at 15 39 21

on https://developers.poki.com/player-device-report/ support for this extension is 5%, which matches 5% of devices support only WebGL1:

Screenshot 2024-01-19 at 15 40 12

@mvaligursky mvaligursky self-assigned this Jan 19, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jan 19, 2024
@mvaligursky mvaligursky requested a review from a team January 19, 2024 15:44
@marklundin
Copy link
Member

The ES5 engine build does seem to target IE11. Is that an issue?

@mvaligursky
Copy link
Contributor Author

@mvaligursky
Copy link
Contributor Author

We'll need to fix the build to remove IE11 support as well.

@mvaligursky mvaligursky mentioned this pull request Jan 19, 2024
2 tasks
@mvaligursky mvaligursky merged commit 2fdee80 into main Jan 22, 2024
@mvaligursky mvaligursky deleted the mv-remove-VAO-polyfill branch January 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants