Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spread to handle variadic args of path.join #5961

Merged
merged 2 commits into from Jan 22, 2024
Merged

Conversation

willeastcott
Copy link
Contributor

Changes this:

image

To this:

image

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott added the docs Documentation related label Jan 22, 2024
@willeastcott willeastcott self-assigned this Jan 22, 2024
@willeastcott willeastcott merged commit 3c7971b into main Jan 22, 2024
7 checks passed
@willeastcott willeastcott deleted the path-join-args branch January 22, 2024 12:05
@kungfooman
Copy link
Collaborator

Very nice, proper argument names help a lot. Currently RTI.js is generating a list of every one of them:

[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/path.js
[0] [0] generateTypeChecks> join> Missing param: section
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/string.js
[0] [0] generateTypeChecks> fromCodePoint> Missing param: args
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/tags.js
[0] [0] generateTypeChecks> Tags#add> Missing param: name
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/tags.js
[0] [0] generateTypeChecks> Tags#remove> Missing param: name
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/tags.js
[0] [0] generateTypeChecks> Tags#has> Missing param: query
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/scene/graph-node.js
[0] [0] generateTypeChecks> GraphNode#findByTag> Missing param: query
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/core/math/curve-set.js
[0] [0] generateTypeChecks> CurveSet#constructor> Missing param: curveKeys
[0] [0] [WARN] /var/www/html/playcanvas-engine-rti/src/framework/asset/asset-registry.js
[0] [0] generateTypeChecks> AssetRegistry#findByTag> Missing param: query

(first one you fixed here)

Should the others also be fixed?

@willeastcott
Copy link
Contributor Author

The others do need fixing, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants