Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing XR exports #5971

Merged
merged 3 commits into from Jan 24, 2024
Merged

Add missing XR exports #5971

merged 3 commits into from Jan 24, 2024

Conversation

marklundin
Copy link
Member

Re-exports XRFinger and XrHand in the index.js output. This also includes them in Typedoc output

Fixes #5966

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@@ -364,6 +364,8 @@ export { XrAnchors } from './framework/xr/xr-anchors.js';
export { XrAnchor } from './framework/xr/xr-anchor.js';
export { XrPlaneDetection } from './framework/xr/xr-plane-detection.js';
export { XrPlane } from './framework/xr/xr-plane.js';
export { XrHand } from './framework/xr/xr-hand.js';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort those alphabetically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this. See #5972

@marklundin marklundin changed the title Missing xr exports Add missing XR exports Jan 24, 2024
@marklundin marklundin merged commit b5f3e1d into main Jan 24, 2024
7 checks passed
@marklundin marklundin deleted the missing-xr-exports branch January 24, 2024 09:05
@marklundin marklundin mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing TypeDoc classes
2 participants