Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo refactor #5975

Merged
merged 39 commits into from Jan 24, 2024
Merged

Gizmo refactor #5975

merged 39 commits into from Jan 24, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jan 24, 2024

  • Renamed files to put Gizmo as the suffix
  • Removes exposure of unnecessary attributes (app, camera etc.)
  • Moved key handling outside gizmo class
  • JSDoc for getters/setters for typedoc
  • Changed deprecated scale to mulScalar

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd self-assigned this Jan 24, 2024
@kpal81xd kpal81xd requested a review from a team January 24, 2024 14:04
@kpal81xd kpal81xd added docs Documentation related area: graphics Graphics related issue area: examples and removed area: graphics Graphics related issue labels Jan 24, 2024
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
extras/gizmo/rotate-gizmo.js Outdated Show resolved Hide resolved
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
Co-authored-by: Will Eastcott <will@playcanvas.com>
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
Co-authored-by: Will Eastcott <will@playcanvas.com>
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
Co-authored-by: Will Eastcott <will@playcanvas.com>
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
Co-authored-by: Will Eastcott <will@playcanvas.com>
extras/gizmo/gizmo.js Outdated Show resolved Hide resolved
kpal81xd and others added 6 commits January 24, 2024 16:40
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely polished! ✨

Co-authored-by: Will Eastcott <will@playcanvas.com>
@kpal81xd kpal81xd merged commit 020e5f3 into main Jan 24, 2024
@kpal81xd kpal81xd deleted the gizmo-refactor branch January 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants