Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AppOptions and correct its types #5986

Merged
merged 2 commits into from Feb 8, 2024
Merged

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 25, 2024

@mvaligursky mvaligursky self-assigned this Jan 25, 2024
@mvaligursky
Copy link
Contributor Author

What am I missing here @kungfooman ?

Error: build/playcanvas.d.ts(22879,30): error TS2693: 'ResourceHandler' only refers to a type, but is being used as a value here.

@kungfooman
Copy link
Collaborator

@mvaligursky You can't do typeof on an interface, that's why I tried to push it here a bit: #5882 (comment)

In short, we have to come to a solution here: #5574 (looks kinda minor, but no response since November last year)

@mvaligursky
Copy link
Contributor Author

I suspected this :(
Well, we're switching from jsdocs to tsdocs just now .. so that issue might go away I hope.

@mvaligursky
Copy link
Contributor Author

Actually, that won't help. We need the fix / refactor you mentioned.

@mvaligursky mvaligursky requested a review from a team February 8, 2024 13:30
@mvaligursky mvaligursky marked this pull request as ready for review February 8, 2024 14:16
@mvaligursky mvaligursky merged commit eddbd9f into main Feb 8, 2024
7 checks passed
@mvaligursky mvaligursky deleted the mv-appoptions-types branch February 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants