Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-app example #6020

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

erikdubbelboer
Copy link
Contributor

createApp just needs to return the app. The introduction of assetListLoader moved the return statement to the wrong place.

Fixes #6018

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

createApp just needs to return the app. The introduction of
assetListLoader moved the return statement to the wrong place.
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvaligursky mvaligursky merged commit b85b355 into playcanvas:main Jan 30, 2024
7 checks passed
mvaligursky pushed a commit that referenced this pull request Feb 2, 2024
createApp just needs to return the app. The introduction of
assetListLoader moved the return statement to the wrong place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-app example issue
2 participants