Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for debug rendering obbs #6023

Merged
merged 2 commits into from Jan 31, 2024
Merged

Add support for debug rendering obbs #6023

merged 2 commits into from Jan 31, 2024

Conversation

slimbuck
Copy link
Member

Add optional matrix so debug AABB rendering can be oriented.

@slimbuck slimbuck added area: graphics Graphics related issue enhancement labels Jan 30, 2024
@slimbuck slimbuck requested a review from a team January 30, 2024 11:53
@slimbuck slimbuck self-assigned this Jan 30, 2024
@mvaligursky
Copy link
Contributor

We discussed this here: #3073 (comment)
I was keen to add it back then, but it was agreed to keep those outside of the code engine. Perhaps this can be still outside?

@mvaligursky
Copy link
Contributor

Lets add it, and create a ticket to move all these non-pubic rendering helpers to extras for now?

mvaligursky
mvaligursky approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts @willeastcott ?

@mvaligursky
Copy link
Contributor

Created an issue: #6024

@slimbuck slimbuck merged commit 4538fc9 into playcanvas:main Jan 31, 2024
7 checks passed
@slimbuck slimbuck deleted the debug-obb branch January 31, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slimbuck @mvaligursky @willeastcott