New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples cleanup (2nd pass) #6041
Conversation
…ames and commented scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I recommend updating this PR to include the thumbs in WebP format instead of PNG. |
I use I like to have the screenshots in the repo and luckily the dist/thumbnails folder is only 8 MB right now. We could probably also add the generated HTML files and make them work as-is (so devs can simply clone the repo into any web root and are able to hack away with only a |
Ahh okay that makes sense. Yea im gonna redo the import map and get the examples generated properly instead of the current template system to allow for actual |
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.