Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename playcanvas-extras build #6075

Merged
merged 3 commits into from Feb 21, 2024
Merged

Rename playcanvas-extras build #6075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c56bc2
Renamed playcanvas-extras.mjs
marklundin Feb 21, 2024
9c171b4
Fixed issue preventing examples from building
marklundin Feb 21, 2024
d116494
Merge branch 'main' into extras-rename
marklundin Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -83,7 +83,7 @@
"build/playcanvas.prf.mjs",
"build/playcanvas.d.ts",
"build/playcanvas-extras.js",
"build/playcanvas-extras.mjs",
"build/playcanvas-extras/index.js",
"scripts",
"LICENSE",
"package.json",
Expand Down Expand Up @@ -146,7 +146,7 @@
"build:treenet": "npm run build:es5 -- --environment treenet",
"build:treesun": "npm run build:es5 -- --environment treesun",
"build:types": "npm run build:dts && node utils/types-fixup.mjs && rollup -c --environment target:types && node utils/types-undollar.mjs && npm run build:types:extras",
"build:types:extras": "tsc extras/index.js --allowJs --declaration --emitDeclarationOnly --outDir build/playcanvas-extras.mjs",
"build:types:extras": "tsc extras/index.js --allowJs --declaration --emitDeclarationOnly --outDir build/playcanvas-extras",
"build:sourcemaps": "npm run build -- -m",
"build:publish": "npm run build && npm run build:types",
"watch": "npm run build -- -w",
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.mjs
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@ console.log(`Building PlayCanvas Engine v${version} revision ${revision}`);

const target_extras = [
scriptTarget('pcx', 'extras/index.js', 'build/playcanvas-extras.js'),
scriptTargetEs6('pcx', 'extras/index.js', 'build/playcanvas-extras.mjs'),
scriptTargetEs6('pcx', 'extras/index.js', 'build/playcanvas-extras'),
scriptTarget('VoxParser', 'scripts/parsers/vox-parser.mjs')
];

Expand Down
2 changes: 1 addition & 1 deletion utils/rollup-build-target.mjs
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ const stripFunctions = [
* @param {Boolean} [shouldBundle] - Whether the target should be bundled.
* @returns {RollupOptions} One rollup target.
*/
function buildTarget(buildType, moduleFormat, input = 'src/index.js', buildDir = 'build', shouldBundle = false) {
function buildTarget(buildType, moduleFormat, input = 'src/index.js', buildDir = 'build', shouldBundle = true) {
const banner = {
debug: ' (DEBUG)',
release: ' (RELEASE)',
Expand Down