Mesh collision optimization #6087
Conversation
|
We could probably change that for Model Assets as well, but I am not too familiar with the legacy format. Can the nodes on model mesh instances be of any other scale, than 1? |
|
Thanks for the PR @LeXXik . |
mvaligursky
added
performance
| const scaling = system._getNodeScaling(node); | ||
| triMeshShape.setLocalScaling(scaling); | ||
| Ammo.destroy(scaling); | ||
| if (!scale) { |
There was a problem hiding this comment.
I wonder if instead of passing the scale parameter to the function, and then either using it, or extracting it from the node, we should not pass it in, and always extract it from the node? And apply directly to vertices that you introduced here. I'm just not sure what the advantage is in having to pass it in, considering we can extract it from the node?
There was a problem hiding this comment.
Hmm, in case of Render Asset that node is a temp node, which will always have a scale 1, so not needed. In case of Model Asset it will be a node from the mesh instance. I wasn't sure if nodes on model mesh instances could have a different scale, so left it there as is.
There was a problem hiding this comment.
I see .. there were two places we apply scale to ammo mesh. One is based on the node of the mesh-instance, and the other is based on the node of the collision component. Your change only handles the first of those.
I somehow assumed we have just one scale applied.
This is a follow up on #5818
After we have created a mesh collider, the engine proceeds with setting the scale of the mesh. This is an expensive operation in Ammo, as it triggers another loop over all verts and recalculating AABB, which was already calculated once when we created
btBvhTriangleMeshShape.Since we are already looping over verts on JS side, we can apply scale in place instead.
This. further improves collider generation (24k verts) from
~181 msdown to~115 ms.Note:
This optimization is only for Render Asset types. There is no change to legacy Model Assets, which will continue using Ammo scaling as they do now.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.