Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ENV var target #6091

Merged
merged 1 commit into from Feb 26, 2024
Merged

Fix ENV var target #6091

merged 1 commit into from Feb 26, 2024

Conversation

marklundin
Copy link
Member

@marklundin marklundin commented Feb 26, 2024 •
edited

This PR adds a fix to prevent the ES6 builds from running when the _target es5 is set.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@marklundin marklundin added the bug label Feb 26, 2024
@marklundin marklundin self-assigned this Feb 26, 2024
mvaligursky
mvaligursky approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it fixes my debug_es5 npm run watch :)

@marklundin marklundin merged commit 09c28bd into main Feb 26, 2024
7 checks passed
@marklundin marklundin deleted the build-target-patch branch February 26, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@marklundin marklundin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marklundin @mvaligursky