Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny splat shader refactoring #6106

Merged
merged 1 commit into from Mar 7, 2024

Conversation

kemchenj
Copy link
Contributor

@kemchenj kemchenj commented Mar 4, 2024

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

The performance should be slightly better, and the rendering stays the same:

Screenshot 2024-03-04 at 22 44 59

@kemchenj
Copy link
Contributor Author

kemchenj commented Mar 4, 2024

To extract the maximum performance, I actually think it's necessary to add a uniform matrix_model_view, which should be calculated on the CPU side in one go to reduce redundant calculations on the GPU side.

This is especially true for cases like Gaussian Splatting, where the amount of vertex computations is particularly large.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@mvaligursky mvaligursky merged commit 7f0dc9f into playcanvas:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants