Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine export fixes #6109

Merged
merged 1 commit into from Mar 5, 2024
Merged

Engine export fixes #6109

merged 1 commit into from Mar 5, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 5, 2024

Fixes #6105

  • Adds import and require to package.json for importing in svelte
  • Adds plugin to add /* @vite-ignore */ to dynamic imports to suppress vite warning for failed dynamic-import-vars plugin resolution
  • Adds import and require for path extras & bundled module (required playcanvas recursive dependency in package.json)

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd added the bug label Mar 5, 2024
@kpal81xd kpal81xd self-assigned this Mar 5, 2024
@kpal81xd kpal81xd requested review from marklundin and a team March 5, 2024 14:15
@kpal81xd kpal81xd merged commit 7bf416b into main Mar 5, 2024
7 checks passed
@kpal81xd kpal81xd deleted the engine-exports-fixes branch March 5, 2024 14:46
@@ -94,7 +104,8 @@
],
"dependencies": {
"@types/webxr": "^0.5.7",
"@webgpu/types": "^0.1.38"
"@webgpu/types": "^0.1.38",
"playcanvas": "file:."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for Vite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopped working with SvelteKit / Vite SSR
3 participants