Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples build fix #6119

Merged
merged 1 commit into from Mar 7, 2024
Merged

Examples build fix #6119

merged 1 commit into from Mar 7, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Mar 7, 2024

  • Fixed examples building issue with importing from subpath

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@kpal81xd kpal81xd self-assigned this Mar 7, 2024
@kpal81xd kpal81xd requested a review from a team March 7, 2024 12:11
@kpal81xd kpal81xd added the bug label Mar 7, 2024
@kpal81xd kpal81xd merged commit 5b7876e into main Mar 7, 2024
6 of 7 checks passed
@kpal81xd kpal81xd deleted the examples-path-import-fix branch March 7, 2024 12:16
@kungfooman
Copy link
Collaborator

The comment above can then also be removed:

// Don't include all of 'playcanvas' for these defines, it just
// causes bigger bundles and prolongs the build time by ~3s.

(not sure how it currently pans out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants